Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] add migration to switch tile layers with EMS_TMS source to vector tile layer #43777

Merged
merged 4 commits into from
Aug 24, 2019
Merged

[Maps] add migration to switch tile layers with EMS_TMS source to vector tile layer #43777

merged 4 commits into from
Aug 24, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 22, 2019

fixes #43488

This PR adds a migration script to migrate map saved objects, converting tile layers with EMS_TMS source to vector tile layers

To test,
Import the following saved object before checking out the branch

{"attributes":{"bounds":{"coordinates":[[[-180,84.21821],[-180,-84.21821],[180,-84.21821],[180,84.21821],[-180,84.21821]]],"type":"Polygon"},"description":"","layerListJSON":"[{\"sourceDescriptor\":{\"type\":\"EMS_TMS\",\"isAutoSelect\":true},\"id\":\"9ce07a33-68ad-4207-ad5a-c0995558b40b\",\"label\":null,\"minZoom\":0,\"maxZoom\":24,\"alpha\":1,\"visible\":true,\"applyGlobalQuery\":true,\"style\":{},\"type\":\"TILE\"}]","mapStateJSON":"{\"zoom\":0.5,\"center\":{\"lon\":0,\"lat\":0},\"timeFilters\":{\"from\":\"now-15m\",\"to\":\"now\"},\"refreshConfig\":{\"isPaused\":false,\"interval\":0},\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filters\":[]}","title":"map with raster EMS tiles","uiStateJSON":"{\"isLayerTOCOpen\":true,\"openTOCDetails\":[]}"},"id":"e1e6b040-c45f-11e9-b475-b74e327fb341","migrationVersion":{"map":"7.2.0"},"references":[],"type":"map","updated_at":"2019-08-21T22:06:10.244Z","version":"Wzc0LDFd"}

Open the saved object in the maps application and verify the map is loading png tiles by viewing the network tab in the browser dev tools.

Stop Kibana, checkout this branch, then restart kibana. Re-open this saved object in the maps app. Verify tiles are now vector tiles (.pbf, Protocolbuffer Binary Format) in network tab

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 22, 2019
@nreese nreese requested a review from nickpeihl August 22, 2019 14:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

nickpeihl
nickpeihl approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nreese nreese merged commit 14a8192 into elastic:master Aug 24, 2019
nreese added a commit to nreese/kibana that referenced this pull request Aug 24, 2019
@nreese
[Maps] add migration to switch tile layers with EMS_TMS source to ve…
fcc3981 
…ctor tile layer (elastic#43777)

* [Maps] add migration to switch tile layers with EMS_TMS source to vector tile layers

* update migration on sample data saved objects since they have already been migrated

* update jest test expect
@nreese nreese mentioned this pull request Aug 24, 2019
Merged
nreese added a commit that referenced this pull request Aug 24, 2019
@nreese
[Maps] add migration to switch tile layers with EMS_TMS source to ve…
d31a389 
…ctor tile layer (#43777) (#43933)

* [Maps] add migration to switch tile layers with EMS_TMS source to vector tile layers

* update migration on sample data saved objects since they have already been migrated

* update jest test expect
@tylersmalley tylersmalley mentioned this pull request Dec 10, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Add migration script to migrate raster EMS layers to vector EMS layers
3 participants
@nreese @elasticmachine @nickpeihl